This repository was archived by the owner on Jul 15, 2023. It is now read-only.
keep component alive during page transition#388
Closed
guins wants to merge 1 commit intosurmon-china:swiper5from
Closed
keep component alive during page transition#388guins wants to merge 1 commit intosurmon-china:swiper5from
guins wants to merge 1 commit intosurmon-china:swiper5from
Conversation
|
@guins is the owner of this repo still alive? He hasn't done any commits in past 3 months |
|
@surmon-china can we get some love for this project and pull-request |
|
To get working, don't forget to set <swiper :cleanStylesOnDestroy="false" ref="mySwiper"></swiper>Thanks @guins for the fix! |
DarkRiDDeR
added a commit
to DarkRiDDeR/vue-swiper-ave2
that referenced
this pull request
Apr 30, 2019
Owner
|
Thanks! v4.0.0 new feature:
|
Merged
Owner
|
Merged! here, enjoy it! |
|
Thank you busy updating our packages at the moment. appreciated this @surmon-china |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I added a
cleanStylesOnDestroyprops, so we can prevent the component from cleaning Swiper styles during thebeforeDestroylifecycle event. Indeed thebeforeDestroyevent is emitted right away when a component should be removed, even if the component (or one of its parents) have a transition out animation. So this allows you to keep the component alive, and properly styled, during a page transition.