This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Closed
Conversation
|
Having this problem as well. I think Vue should wait until the transition is complete to call beforeDestroy. |
|
@arcs- Destroying swiper in the parent components' beforeDestroy() seems to work: Might be useful if added to readme @surmon-china |
Owner
|
Thanks! v4.0.0 new feature:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a SPA one may have a transition from one page to another. Vue will call the beforeDestroy listener before the transition is over. To compensate this change adds a delay of 1 second before the slider gets destroyed.
Other solutions are welcome but I couldn't find one in the few minutes I had. This change should not have a negative impact on any application as it only delays the removal.