Unable to deconstruct an object that has a reserved keyword

[pushkine]

https://svelte.dev/repl/8ec7ec1e072b405d90549a5277a9f235?version=3.18.1

[PatrickG]

That's not possible in plain JavaScript either.

[TehShrike]

@pushkine const { in: value } = { value: 12 } is a syntax error in JS: https://jsfiddle.net/uakgp9ho/

So, it will be a syntax error in Svelte too.

[pushkine]

@TehShrike your fiddle makes no sense
here it is corrected : https://jsfiddle.net/2n8efqh0/
jsfiddle does underline the keyword but the console doesn't output any error, hinting this is not a javascript issue but a linter one
I see no reason why one couldn't use a reserved keyword as a object property name

[TehShrike]

Hey, you're right

[Conduitry]

I believe we're currently using some custom parsing logic for the array/object destructuring in each blocks, and that probably doesn't realize that in can be used there in that way if it's trying to parse in by itself as an identifier. I'm not sure the reason we're not using Acorn to try to parse these (maybe because it wouldn't play nice with the parenthesized key afterwards?), but it seems like it would be nice if we could get that to happen.

[Conduitry]

Apparently all the way back to 3.0.0, the compiler has never balked at doing something like {in} or {class}, which it definitely should, as that results in invalid code: text(in) or text(class).

[Conduitry]

Actually that's probably just a matter of removing the special handling added way back in #385.