Skip to content

get store() to work with nested components in SSR compiler#1029

Merged
Rich-Harris merged 1 commit intomasterfrom
gh-1028-followup
Dec 16, 2017
Merged

get store() to work with nested components in SSR compiler#1029
Rich-Harris merged 1 commit intomasterfrom
gh-1028-followup

Conversation

@Rich-Harris
Copy link
Copy Markdown
Member

For store() to work in SSR mode, we need to add it to options.store

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 16, 2017

Codecov Report

Merging #1029 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage      92%   91.99%   -0.01%     
==========================================
  Files         119      119              
  Lines        4363     4362       -1     
  Branches     1406     1406              
==========================================
- Hits         4014     4013       -1     
  Misses        148      148              
  Partials      201      201
Impacted Files Coverage Δ
src/generators/server-side-rendering/index.ts 95.77% <50%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 733e949...f7c540b. Read the comment docs.

@Rich-Harris Rich-Harris merged commit a5f816f into master Dec 16, 2017
@Rich-Harris Rich-Harris deleted the gh-1028-followup branch December 16, 2017 17:05
sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
* day 16

* missing title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants