fix #1240#1243
Merged
Rich-Harris merged 4 commits intomasterfrom Mar 18, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
==========================================
- Coverage 91.9% 91.82% -0.08%
==========================================
Files 126 126
Lines 4557 4700 +143
Branches 1486 1544 +58
==========================================
+ Hits 4188 4316 +128
- Misses 153 161 +8
- Partials 216 223 +7
Continue to review full report at Codecov.
|
Member
Author
|
Have checked the original REPL example locally and it's fixed as of this PR. This feels like the right solution; now just need to stop passing around context values that aren't necessary (#1194) |
This was referenced Mar 19, 2018
7nik
pushed a commit
to 7nik/svelte
that referenced
this pull request
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solution in this PR doesn't work; in fact it highlights the fact that the current approach has fatal flaws. Leaving it here for posterity (along with the previously-failing test)