when mounting dynamic components, set ref if required#1280
Merged
Rich-Harris merged 2 commits intomasterfrom Mar 27, 2018
Merged
when mounting dynamic components, set ref if required#1280Rich-Harris merged 2 commits intomasterfrom
Rich-Harris merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
+ Coverage 91.51% 91.57% +0.05%
==========================================
Files 121 121
Lines 4326 4330 +4
Branches 1361 1363 +2
==========================================
+ Hits 3959 3965 +6
Misses 153 153
+ Partials 214 212 -2
Continue to review full report at Codecov.
|
Member
Author
|
I realized I'm not actually sure about |
Member
yeah. it's used inconsistently, and often results in weird spacing to be honest. there's probably a better way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs to dynamic components weren't being set during mounting, only during updates. This fixes that and adds a test.
cc @heardy