output { js, css, ast } from svelte.compile#1298
Merged
Rich-Harris merged 3 commits intomasterfrom Apr 1, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
- Coverage 91.66% 91.65% -0.01%
==========================================
Files 122 122
Lines 4332 4339 +7
Branches 1367 1369 +2
==========================================
+ Hits 3971 3977 +6
Misses 148 148
- Partials 213 214 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #795. This replaces the existing hodgepodge...
...with something a bit saner:
jsandcssare both{ code, map }objects.The old properties are preserved (to the extent possible, by giving the
cssobjectString.prototypemethods) in a way that should be non-breaking in all but the most edgy of cases (tested with rollup-plugin-svelte and svelte-loader). Once plugins have had a chance to update, we can start adding deprecation warnings, before a removal in v2.Next up, #1257.