deprecate get with string argument#1347
Merged
Rich-Harris merged 1 commit intomasterfrom Apr 17, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1347 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 127 127
Lines 4542 4542
Branches 1446 1446
=======================================
Hits 4166 4166
Misses 151 151
Partials 225 225Continue to review full report at Codecov.
|
This was referenced Apr 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it makes sense to get this warning into one of the final v1 releases, to ease migration