refactor#1367
Merged
Rich-Harris merged 86 commits intomasterfrom Apr 29, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1367 +/- ##
==========================================
- Coverage 91.49% 91.11% -0.39%
==========================================
Files 126 120 -6
Lines 4469 4421 -48
Branches 1384 1360 -24
==========================================
- Hits 4089 4028 -61
- Misses 154 156 +2
- Partials 226 237 +11
Continue to review full report at Codecov.
|
Member
Author
|
At long last, the diff is now more red than green. Will probably find a few more things to tidy up but I reckon this is basically ready — going to remove the [WIP] label. Most apps should get slightly smaller as a result of this PR, due to the way context is kept up to date. |
Member
Author
|
@Conduitry ah, good catch, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1316.
Lots more work to do here, but I'm optimistic about the direction it's going in. Essentially the goals are:
contextualisestuffI found myself leaning towards a couple of naming changes — internally,
generatoris referred to more simply ascompiler, and in the generated code,statebecomesctx, since it's more appropriate to speak of a 'context' once you're inside each/await blocks.