Destructuring#1385
Merged
Rich-Harris merged 4 commits intomasterfrom Apr 29, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
==========================================
+ Coverage 91.21% 91.24% +0.02%
==========================================
Files 120 122 +2
Lines 4429 4454 +25
Branches 1362 1367 +5
==========================================
+ Hits 4040 4064 +24
- Misses 154 156 +2
+ Partials 235 234 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the existing
destructuredContextsmechanism to support arbitrary destructuring forms, so that you can do this sort of thing:{#each things as { x: [y, z] } } <p>{z}</p> {/each}More realistically, you could use it for simple object pattern destructuring, but I didn't see any reason to arbitrarily restrict the patterns you could use. For now it doesn't support assignment patterns — we'll see if those turn out to be necessary. (They're a little finicky to parse.)
TODO