[WIP] Unmount nodes in destroy methods#1421
Merged
Rich-Harris merged 3 commits intomasterfrom May 5, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
- Coverage 91.23% 91.07% -0.16%
==========================================
Files 122 122
Lines 4493 4484 -9
Branches 1394 1400 +6
==========================================
- Hits 4099 4084 -15
- Misses 153 158 +5
- Partials 241 242 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
block.u()is always followed byblock.d(). The reason for the separation is that we sometimes want to 'destroy' something without detaching it, if it's inside a parent element that has been destroyed.It seems like it would make more sense to combine the two things. For one thing it results in less code. For another, I think there were cases previously where we were detaching unnecessarily; that shouldn't happen any more.