Add new ARIA 1.1 attributes and roles#1436
Merged
Rich-Harris merged 1 commit intosveltejs:masterfrom May 10, 2018
maxmilton:feat/wai-aria-1.1-update
Merged
Add new ARIA 1.1 attributes and roles#1436Rich-Harris merged 1 commit intosveltejs:masterfrom maxmilton:feat/wai-aria-1.1-update
Rich-Harris merged 1 commit intosveltejs:masterfrom
maxmilton:feat/wai-aria-1.1-update
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
=======================================
Coverage 91.09% 91.09%
=======================================
Files 122 122
Lines 4491 4491
Branches 1406 1406
=======================================
Hits 4091 4091
Misses 158 158
Partials 242 242
Continue to review full report at Codecov.
|
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the new ARIA attributes and roles as defined in https://www.w3.org/TR/wai-aria-1.1/.
I found which attr/roles had changed via:
Originally I just wanted to use the new
aria-role=switchin one of my components but as it turns out there's a bunch of new additions worth adding.