Move addEventListener, removeEventListener, setAttribute into shared#227
Merged
Rich-Harris merged 1 commit intosveltejs:masterfrom Jan 3, 2017
Conduitry:share-more
Merged
Move addEventListener, removeEventListener, setAttribute into shared#227Rich-Harris merged 1 commit intosveltejs:masterfrom Conduitry:share-more
Rich-Harris merged 1 commit intosveltejs:masterfrom
Conduitry:share-more
Conversation
Member
|
+1 for setAttribute, if you put an SVG into svelte form there's literally hundreds of these. |
Member
|
nice, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like there are a few more things that can be split off into shared functions to reduce code duplication. In this PR, I'm moving the
.addEventListener,.removeEventListener, and.setAttributecalls into shared functions. This further decreases the (minified, ungzipped) code size.