escape @ sigils in debug filename#3114
Merged
Conduitry merged 1 commit intosveltejs:masterfrom Jun 25, 2019
Merged
Conversation
Conduitry
force-pushed
the
escape-sigil-filename
branch
from
deafb3a to
8ba428f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the changes in #2963 was to throw an error when decoding a
@sigil that wasn't actually exported fromsvelte/internal. This causes a problem when we neglect to properly escape this elsewhere, like what was happening in the debug filename. When the filename included, for example,@sapper, this would throw an error. We're now properly escaping the sigil.