Skip to content

handle implicitly closed elements#318

Merged
Rich-Harris merged 1 commit intomasterfrom
implicitly-closed-elements
Mar 1, 2017
Merged

handle implicitly closed elements#318
Rich-Harris merged 1 commit intomasterfrom
implicitly-closed-elements

Conversation

@Rich-Harris
Copy link
Copy Markdown
Member

Starting to dig into #258 and #224 and related issues. As a starting point, Svelte needs to do a better job of handling situations like these:

<!-- the <p> is never closed, but that's totally fine in HTML -->
<div><p>some text</div>

<!-- these <li> elements don't need closing tags -->
<ul>
  <li>a
  <li>b
  <li>c
</ul>

This PR addresses both cases, by noting which elements are forbidden from containing which other elements, and by closing all currently open elements until the one that corresponds to a particular closing tag

@Rich-Harris Rich-Harris merged commit c2275f3 into master Mar 1, 2017
@Rich-Harris Rich-Harris deleted the implicitly-closed-elements branch March 1, 2017 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant