add development warnings for missing data properties#320
Merged
Rich-Harris merged 1 commit intomasterfrom Mar 1, 2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a start on #13 — it introduces
dev: trueas an option for adding development warnings, and kicks things off by throwing an error if a template references a property that isn't present on the initial data object (something we can't know until runtime).We can iterate on the specifics of the error message (e.g. it could include a link to some documentation explaining what the message means, and that you can fix it my initialising with null data), but at least now we have something to work with, and the infrastructure to test it