bugfix: exempt the :root psuedo-selector from the random css prefix#3250
Merged
Rich-Harris merged 1 commit intosveltejs:masterfrom Jul 23, 2019
davemo:fix/1705-root-pseudo-selector-prefix-exemption
Merged
bugfix: exempt the :root psuedo-selector from the random css prefix#3250Rich-Harris merged 1 commit intosveltejs:masterfrom davemo:fix/1705-root-pseudo-selector-prefix-exemption
Rich-Harris merged 1 commit intosveltejs:masterfrom
davemo:fix/1705-root-pseudo-selector-prefix-exemption
Conversation
- the change in #1705 introduced a small bug for users who were relying on assigning global CSS variables via the :root selector - this change adds a small exemption to avoid prefixing :root with the random prefix that svelte adds
Member
|
Thanks — the purist in me chafes at treating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:rootpseudo-selector with the random prefix that svelte addshere is a screenshot that illustrates the bug (pre 3.6.3 [working], post 3.6.3 [broken]), and the corresponding source in my
App.sveltecomponent file: