Skip to content

feat order attributes + actions too#4156

Merged
Conduitry merged 2 commits intosveltejs:masterfrom
tanhauhau:tanhauhau/order-directives-include-actions
Dec 24, 2019
Merged

feat order attributes + actions too#4156
Conduitry merged 2 commits intosveltejs:masterfrom
tanhauhau:tanhauhau/order-directives-include-actions

Conversation

@tanhauhau
Copy link
Copy Markdown
Member

Fixes: #2446

  • Include the action into sort
  • Note:
    • Add actions using block.event_listeners.push
    • actions is now added in c instead of m.
      • probably will affect (+ fix ?) hydration, since m is not called in hydration (iirc)

@tanhauhau tanhauhau force-pushed the tanhauhau/order-directives-include-actions branch from 92312c3 to b433440 Compare December 24, 2019 11:32
Comment thread src/runtime/internal/utils.ts
@Conduitry Conduitry merged commit 52dbc88 into sveltejs:master Dec 24, 2019
@Conduitry
Copy link
Copy Markdown
Member

Released in 3.16.7.

@tanhauhau tanhauhau deleted the tanhauhau/order-directives-include-actions branch December 24, 2019 19:46
@tanhauhau tanhauhau mentioned this pull request Mar 1, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Co-authored-by: Conduitry <git@chor.date>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply directives in order

2 participants