More helpful validation#473
Merged
Rich-Harris merged 4 commits intomasterfrom Apr 13, 2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to clear out the easy-to-tackle stuff from the issues list. This closes #166, with some analysis of
helpersandmethods(andnamespace, while I was at it):on:click='foo()') are checked to ensure thatfoois a valid method. Valid methods areset,fireand anything custom.this.*andevent.*are also permittedfoodoesn't exist onmethodsbut it does exist onhelpers, Svelte asks if it was put in the wrong placethis.get('x')— common mistake — it errors, tells you to pass it in as an argument instead (we could also do this for computed values)this, it errors, telling you that helper functions must be pure and have no access to the component instance, and suggesting that it belongs onmethodsargumentsis not used, it warns you that helpers should be purehttpsinstead ofhttp.