fix: typing get svelte/store#5483
Merged
Conduitry merged 1 commit intosveltejs:masterfrom Oct 1, 2020
Merged
Conversation
dummdidumm
approved these changes
Oct 1, 2020
4 tasks
Member
|
This has been released in 3.29.3, thanks! |
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new typing for get_store_value introduced in 3.29.0 doesn't work and generates multiple
Object is of type 'unknown'.errors in our codebase.See the
.D.TStab in playground to see that typescript thinks the return value isunknown.Demo of the fix: playground