Style tags that were not at top level were missing end attribute#5487
Merged
Conduitry merged 2 commits intosveltejs:masterfrom Oct 2, 2020
Merged
Style tags that were not at top level were missing end attribute#5487Conduitry merged 2 commits intosveltejs:masterfrom
Conduitry merged 2 commits intosveltejs:masterfrom
Conversation
ehrencrona
commented
Oct 2, 2020
| "children": [ | ||
| { | ||
| "start": 13, | ||
| "end": 28, |
Contributor
Author
There was a problem hiding this comment.
before the code change, this was null
Member
|
Good catch, thank you! And now also with less code |
Member
|
This has been released, thank you! |
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a
styletag was not at the top level, theendproperty of it was empty. This is because the lineelement.end = parser.index;was missing for thestylecase in that changed code.This fixes sveltejs/language-tools#586 and (very likely) fixes sveltejs/prettier-plugin-svelte#149
Before submitting the PR, please make sure you do the following
Tests
npm testand lint the project withnpm run lint