Skip to content

no warning on contextual-store if declaring it as a parameter / variable#6008

Merged
Conduitry merged 3 commits intosveltejs:masterfrom
tanhauhau:tanhauhau/skip-contextual-store-warning
Feb 25, 2021
Merged

no warning on contextual-store if declaring it as a parameter / variable#6008
Conduitry merged 3 commits intosveltejs:masterfrom
tanhauhau:tanhauhau/skip-contextual-store-warning

Conversation

@tanhauhau
Copy link
Copy Markdown
Member

@tanhauhau tanhauhau commented Feb 20, 2021

This PR fix for the following error:

<script>
      function test(store) {
		// should not error when declaring the parameter as `$store`
		return derived(store, $store => {
		});
	}
</script>

Before submitting the PR, please make sure you do the following

  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants