chore: mark nest method this: void for destructing safely#6094
Merged
dummdidumm merged 1 commit intosveltejs:masterfrom Mar 24, 2021
JounQin:fix/this_void
Merged
chore: mark nest method this: void for destructing safely#6094dummdidumm merged 1 commit intosveltejs:masterfrom JounQin:fix/this_void
this: void for destructing safely#6094dummdidumm merged 1 commit intosveltejs:masterfrom
JounQin:fix/this_void
Conversation
dummdidumm
approved these changes
Mar 18, 2021
|
Thank you @JounQin and @dummdidumm, can we merge and release this please? I have dozens of projects with thousands of warnings in CI! 🤣 |
Contributor
Author
|
@dummdidumm Can this PR been merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close sveltejs/eslint-plugin-svelte3#102
Before submitting the PR, please make sure you do the following
Tests
npm testand lint the project withnpm run lint