Skip to content

chore: mark nest method this: void for destructing safely#6094

Merged
dummdidumm merged 1 commit intosveltejs:masterfrom
JounQin:fix/this_void
Mar 24, 2021
Merged

chore: mark nest method this: void for destructing safely#6094
dummdidumm merged 1 commit intosveltejs:masterfrom
JounQin:fix/this_void

Conversation

@JounQin
Copy link
Copy Markdown
Contributor

@JounQin JounQin commented Mar 18, 2021

close sveltejs/eslint-plugin-svelte3#102

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@frederikhors
Copy link
Copy Markdown

frederikhors commented Mar 18, 2021

Thank you @JounQin and @dummdidumm, can we merge and release this please? I have dozens of projects with thousands of warnings in CI! 🤣

@JounQin
Copy link
Copy Markdown
Contributor Author

JounQin commented Mar 24, 2021

@dummdidumm Can this PR been merged?

@dummdidumm dummdidumm merged commit 50dcc2a into sveltejs:master Mar 24, 2021
@JounQin JounQin deleted the fix/this_void branch March 24, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why do I get "Avoid referencing unbound methods which may cause unintentional scoping of this. eslint@typescript-eslint/unbound-method" in this case?

3 participants