Add additional function overload for derived#6172
Merged
lukeed merged 1 commit intosveltejs:masterfrom Apr 9, 2021
Merged
Conversation
lukeed
approved these changes
Apr 7, 2021
Member
lukeed
left a comment
There was a problem hiding this comment.
This is great, and much needed. Ran into it a number of times personally & I know it was a definition that Svelte used to include at some earlier point in the 3.x cycle.
Thanks!
Member
|
Is there a reason why this new signature isn't just the only signature? Are there reasons why this was split out? |
Member
|
@dummdidumm This new signature has no |
Member
|
Silly me, didn't read that other definition closely enough. All good then! |
dummdidumm
approved these changes
Apr 9, 2021
Member
|
Thanks @fielding ! |
Member
|
These types should be published in 3.38.0. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an additional overload for
derivedto allow explicitly setting an initial value for non-async derived stores.Details
After a long overdue svelte version update, I started getting some type errors on any non-async derived store that I had explicitly set an initial value. For example,
Perhaps the correct way to handle the initial value is through the initial values of the stores that it is derived from, but I guess it feels safer to me to also explicitly set it on the derived store.
Assuming that this usage is acceptable then the additional overload keeps typescript happy. 😄
Before submitting the PR, please make sure you do the following
Tests
npm testand lint the project withnpm run lint