Hoist if block selectors#751
Merged
Rich-Harris merged 3 commits intomasterfrom Aug 6, 2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It occurred to me that the
get_blockfunctions, which determine which block to render in a series ofif...elseif...elseblocks, can always be hoisted. Should save a microscopic amount of work whenifblocks are insideeachblocks, with no downside that I can think of.I also renamed
get_blocktoselect_block_type(andcurrent_blocktocurrent_block_type) since I think that's marginally more descriptive of what's happening.