supported "muted" property as boolean on audio element#886
Merged
Rich-Harris merged 1 commit intosveltejs:masterfrom Oct 17, 2017
Merged
supported "muted" property as boolean on audio element#886Rich-Harris merged 1 commit intosveltejs:masterfrom
Rich-Harris merged 1 commit intosveltejs:masterfrom
Conversation
Member
|
thanks!
No, nothing as fancy as that — IIRC I just copied and pasted the table into VSCode and beat it into shape with a bunch of regular expressions. A script would probably have been the smarter way to go... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MDN HTML attribute reference didn't include the
audioelement under themutedproperty. I updated the MDN reference and insertedaudiohere, too. Without this,muted={{ false }}will render themutedproperty onaudioelements, thus muting them (demo).I didn't see any tests for this sort of thing, so I didn't write one.
Is there a script I missed that parses the mdn page for this data? If not, would it be helpful to have one? I might be able to do that shortly.