Add diagnostic group names to several import-related warnings#88639
Open
tshortli wants to merge 7 commits intoswiftlang:mainfrom
Open
Add diagnostic group names to several import-related warnings#88639tshortli wants to merge 7 commits intoswiftlang:mainfrom
tshortli wants to merge 7 commits intoswiftlang:mainfrom
Conversation
Resolves rdar://175381846.
Resolves rdar://147656067.
Contributor
Author
|
@swift-ci please smoke test |
Member
|
There was a recent break in Testing, this pull appears to fix it: @swift-ci smoke test macOS |
Contributor
Author
I don't think that's right. This just adds some diagnostic groups to existing diagnostics. |
Member
|
Right, but that Testing issue had broken all macOS PR CI earlier, completely unrelated to this diagnostic pull. |
Contributor
Author
|
Ok, I see now, I misinterpreted which pull request you were referring to as fixing the issue. It's the swift-testing one that fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Werrorand-Wwarning.