Skip to content

Add diagnostic group names to several import-related warnings#88639

Open
tshortli wants to merge 7 commits intoswiftlang:mainfrom
tshortli:import-warning-groups
Open

Add diagnostic group names to several import-related warnings#88639
tshortli wants to merge 7 commits intoswiftlang:mainfrom
tshortli:import-warning-groups

Conversation

@tshortli
Copy link
Copy Markdown
Contributor

  • Explanation: Adds group names to several import-related warnings so that the diagnostics can be controlled via -Werror and -Wwarning.
  • Scope: Affects projects in which the modified warnings are emitted (though adding a warning group name to a diagnostic that previously did not have one should generally have no effect on existing projects).
  • Issues: rdar://147656067&175381846
  • Risk: Low since adding warning group names to diagnostics that previously did not have them should generally have no effect on existing projects
  • Testing: Modified existing test cases to verify that the behavior of the diagnostics can now be controlled.

@tshortli tshortli requested a review from a team as a code owner April 23, 2026 23:02
@tshortli
Copy link
Copy Markdown
Contributor Author

@swift-ci please smoke test

@finagolfin
Copy link
Copy Markdown
Member

There was a recent break in Testing, this pull appears to fix it:

swiftlang/swift-testing#1688

@swift-ci smoke test macOS

@tshortli
Copy link
Copy Markdown
Contributor Author

tshortli commented Apr 24, 2026

There was a recent break in Testing, this pull appears to fix it:

swiftlang/swift-testing#1688

@swift-ci smoke test macOS

I don't think that's right. This just adds some diagnostic groups to existing diagnostics.

@finagolfin
Copy link
Copy Markdown
Member

Right, but that Testing issue had broken all macOS PR CI earlier, completely unrelated to this diagnostic pull.

@tshortli
Copy link
Copy Markdown
Contributor Author

Ok, I see now, I misinterpreted which pull request you were referring to as fixing the issue. It's the swift-testing one that fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants