'Create review from changes' does not work in latest IDEA 13.4

[alexey-danilov]

How to reproduce:

Changes -> Respository -> selecting some revision -> Create review from changes -> Shared.
Input some name, choose to create a blank review.
In "VCS revision":
'From revision' checkbox is already on. The problem is, File selection uses the default pattern: file[]://* - which means that this review will be created for ALL files.

The quesion: is it somehow possible to automatically preselect only those files, which were changed in-between the specified VCS revisions? If that's not the intention for this option, can you pls try to explain it?

Thanks a lot for developing and supporting this plugin! Keep the good work! :)

[syllant]

Hi Alexey,

If "From revision" option is checked, you should have a revision number displayed beside. If this revision number is empty, this is an issue. Please, provide your log file, your VCS (Git?) and check you are using the last version of the plugin.

Note that when you define a revision number, the file pattern is not impacted. Both are combined, e.g. you can use file pattern to refine files modified in the selected commit.

Sylvain

[alexey-danilov]

Hi Sylvain,

The revision number is not empty, so maybe it is not the issue. I am just a little puzzled: what is the practical use of this feature. The only idea is that it enables "compare for review" action.

So maybe this is rather feature request than a bug report... Idea is that if you select range of revisions, or only starting/end revision for that matter, it should provide file pattern matching only files modified between provided revisions. After all, that's what you most likely will want to review - only the changed files. Of course, such pattern could be easily modified manually (but I see not much need in this).

My current review workflow: select revisions, then manually select files you want to be reviewed (this is not really convenient, because you have to keep track of them manually; this is ok if you commit a couple of files, but still error-prone). Then when the reviewer starts the review, in the project view he selects only the revu scope, clicks the file, invokes "compare for review", then is able to add annotations.

The part which does not seem quite natural to me is manually selecting files for review.

[syllant]

File pattern and revision selection are just 2 independent filters which may be combined to refine the scope of the review.

When you select revisions, you refine the reVu scope: the review will be applied to files which have been modified in the related commits.

However, the file pattern is not changed, it's not related. You can also define the file pattern to filter files already filtered by the revisions.

This is how it's supposed to work.

Sylvain

[alexey-danilov]

Can you please elaborate a little bit about this one: "the review will be applied to files which have been modified in the related commits."

I have a project with, say, 100 files. I select a range of commits where only 5 files were changed.
When somebody starts the review, he will see all the 100 files in the revu scope for this review.

Also not sure if I understand correctly "filter files already filtered by the revisions". Revisions do not filter any files for me

I use SVN client 1.6, built into IDEA. Checkout/commit is being done by IDEA as well. Win7 x64

[syllant]

OK, I understand now you are experiencing an issue with VCS filter: when you select a revision, the reVu scope is not restricted to the files modified in the related commits, whereas it's the expected behavior.

I'm not sure I'll be able to work on this issue for the next 2 weeks, but I'll let you know.

Thank you for your detailed report.

Sylvain

[alexey-danilov]

This feature also is missing in latest EAP of IDEA 14. So would be great if you could take a look :)

[AlekseyKolesnik]

I've tried it with 15 EAP and git (instead of svn). Still the same result.