Merged
Conversation
- Switch markdown lint config and audit scripts to rumdl. - Track rumdl in package-lock and third-party licenses. - Update weather smoke coverage to use the new config.
- Generate Rust dependency artifacts from the supported macOS/Linux target union - Regenerate third-party license and notice artifacts from the stable input set - Add regression coverage for the new artifact contract wording
- Regenerate third-party artifacts after rebasing onto the latest origin/main - Update Cargo.lock fingerprints and rustls-webpki version references to 0.103.10 - Keep PR merge-ref validation aligned with the checked-in artifacts
graysurf
force-pushed
the
feat/replace-markdown-lint-with-rumdl
branch
from
c3506e5 to
b259f85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace markdownlint-cli2 with rumdl
Summary
Replace the repo's Markdown lint implementation with
rumdlwhile keeping the existingscripts/ci/markdownlint-audit.shentrypoint and workflow lint flow intact. Because this repo's third-party artifact contract tracks Node tooling throughpackage-lock.json, this migration also pinsrumdlas a root dev dependency instead of relying on an untracked ad-hocnpxdownload.The PR also stabilizes third-party artifact generation across macOS/Linux runners. The initial
THIRD_PARTY_LICENSES.mdrefresh was host-dependent because the generator used plaincargo metadata --locked; CI now derives Rust dependencies from the union of supported macOS/Linux--filter-platformmetadata so the checked-in artifacts are reproducible on both developer machines and GitHub Actions.Changes
.rumdl.toml, delete.markdownlint-cli2.jsonc, and switch markdown audit callers tonpx --no-install rumdl check.[email protected]topackage.jsonandpackage-lock.json, then regenerateTHIRD_PARTY_LICENSES.md.THIRD_PARTY_LICENSES.mdandTHIRD_PARTY_NOTICES.md, and update the artifact contract docs plus regression test coverage.Testing
bash scripts/ci/markdownlint-audit.sh --strict(pass)bash scripts/generate-third-party-artifacts.sh --write(pass)bash tests/third-party-artifacts/generator.test.sh(pass)bash scripts/ci/third-party-artifacts-audit.sh --strict(pass)scripts/local-pre-commit.sh(pass)Risk / Notes
workflows/weather/tests/smoke.shnow uses the samerumdlconfig path as the shared audit script to keep repo and workflow-specific markdown checks aligned.rumdlis tracked as a root dev dependency so the existing third-party artifact contract can keep deriving Node tool provenance frompackage-lock.json.scripts/generate-third-party-artifacts.shand the contract docs must be updated together.