Conversation
Collaborator
bruth
commented
Nov 17, 2025
bruth
commented
- A Model type has been introduced providing thread-safety
- A Watcher method has been introduced for async evolution
- The Rita type has been renamed to Manager and config standardized
- Options have been standardized with the With prefix
- Expect sequence and subject is now optionally set on each event
- The stream name and subject are standardized
* A Model type has been introduced providing thread-safety * A Watcher method has been introduced for async evolution * The Rita type has been renamed to Manager and config standardized * Options have been standardized with the With prefix * Expect sequence and subject is now optionally set on each event * The stream name and subject are standardized Signed-off-by: Byron Ruth <[email protected]>
Signed-off-by: Byron Ruth <[email protected]>
jordan-rash
reviewed
Nov 17, 2025
Collaborator
jordan-rash
left a comment
jordan-rash
left a comment
There was a problem hiding this comment.
nits only, this is awesome
Signed-off-by: Byron Ruth <[email protected]>
Signed-off-by: Byron Ruth <[email protected]>
jordan-rash
reviewed
Nov 17, 2025
Signed-off-by: Byron Ruth <[email protected]>
Signed-off-by: Byron Ruth <[email protected]>
Signed-off-by: Byron Ruth <[email protected]>
Signed-off-by: Byron Ruth <[email protected]>
Signed-off-by: Byron Ruth <[email protected]>
Collaborator
Author
|
@jordan-rash I need to update the README, but otherwise the code/API is in good shape. I will push a couple more updates here today and then we can merge. |
Collaborator
|
Sounds good to me |
jordan-rash
previously approved these changes
Nov 19, 2025
Signed-off-by: Byron Ruth <[email protected]>
jordan-rash
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.