Conversation
The previous assumption was that a single model would encapsulate the same entity type. This could technically be overridden by setting explicit Expect values on each event manually, but that would require external sequence tracking. Wrapping with Model can do this implicitly and now correctly tracks sequence by entity. Note, memory growth will be proportionate to the number of entities being represented in the model. Signed-off-by: Byron Ruth <byron@synadia.com>
jordan-rash
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous assumption was that a single model would encapsulate the same entity type. This could technically be overridden by setting explicit Expect values on each event manually, but that would require external sequence tracking. Wrapping with Model can do this implicitly and now correctly tracks sequence by entity.
Note, memory growth will be proportionate to the number of entities being represented in the model.
Also, updated the test utility to always use a temp directory to ensure it is isolated and cleaned up properly.