(docs): Move CSS Logical Properties to separate table#1454
Merged
(docs): Move CSS Logical Properties to separate table#1454
Conversation
lachlanjc
added
the
affects-docs
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/2hfl68133 [Deployment for 1a18685 failed] |
atanasster
approved these changes
Jan 20, 2021
hasparus
reviewed
Jan 26, 2021
| import { Box } from 'theme-ui' | ||
|
|
||
| <Box | ||
| ;<Box |
hasparus
reviewed
Jan 26, 2021
|
|
||
| # Hello | ||
|
|
||
| # Hello |
Member
There was a problem hiding this comment.
Wait, this doesn't work, does it?
If you don't wrap markdown in empty lines you're still in JSX, so this won't render a heading, and that # is just printed. I mean, I know that's just a code snippet in the docs, but still.
Member
Author
There was a problem hiding this comment.
You're correct, I believe. I guess we'll just counter Prettier here & figure out how to avoid it in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed when the list was added, the logical properties makes the table super long, so I’ve summarized them & moved them into a details tag.
Preview live: https://theme-ui-git-docs-separate-logical.systemui.vercel.app/sx-prop