android: modify mullvad exit node detection logic#656
Merged
Conversation
Pull Request Revisions
✅ AI review completed for r3 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at team@review.ai. |
ghost
reviewed
May 26, 2025
barnstar
force-pushed
the
jonathan/mullvad-check
branch
from
3bbd6d8 to
f479d50
Compare
updates tailscale/corp#29045 We ran into an issue where the current detection logic was not sufficient to filter out mullvad nodes. This modifies the logic so we scan both the Name and ComputedName for the mullvad domain and also treat all nodes with location info as mullvad nodes. While all of these conditions *should* be true for any mullvad node, in practice it's possible that they aren't so we or them together for some redundancy and define a mullvad exit node to be any node where any of these conditions is true. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
barnstar
force-pushed
the
jonathan/mullvad-check
branch
from
f479d50 to
2b61811
Compare
kari-ts
approved these changes
May 27, 2025
barnstar
added a commit
that referenced
this pull request
May 28, 2025
updates tailscale/corp#29045 We ran into an issue where the current detection logic was not sufficient to filter out mullvad nodes. This modifies the logic so we scan both the Name and ComputedName for the mullvad domain and also treat all nodes with location info as mullvad nodes. While all of these conditions *should* be true for any mullvad node, in practice it's possible that they aren't so we or them together for some redundancy and define a mullvad exit node to be any node where any of these conditions is true. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com> (cherry picked from commit 88a5d3c)
This was referenced Jun 29, 2025
nadeemakhter0602
pushed a commit
to nadeemakhter0602/TailMon
that referenced
this pull request
Mar 22, 2026
updates tailscale/corp#29045 We ran into an issue where the current detection logic was not sufficient to filter out mullvad nodes. This modifies the logic so we scan both the Name and ComputedName for the mullvad domain and also treat all nodes with location info as mullvad nodes. While all of these conditions *should* be true for any mullvad node, in practice it's possible that they aren't so we or them together for some redundancy and define a mullvad exit node to be any node where any of these conditions is true. Signed-off-by: Jonathan Nobels <jonathan@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates tailscale/corp#29045
We ran into an issue where the current detection logic was not sufficient to filter out mullvad nodes. This modifies the logic so we scan both the Name and ComputedName for the mullvad domain and also treat all nodes with location info as mullvad nodes. While all of these conditions should be true for any mullvad node, in practice it's possible that they aren't so we or them together for some redundancy and define a mullvad exit node to be any node where any of these conditions is true.