android: stop watching legacy netmap notifications#797
Merged
Conversation
kari-ts
approved these changes
May 26, 2026
| Capabilities = Capabilities, | ||
| CapMap = CapMap, | ||
| ComputedName = computedName, | ||
| ComputedNameWithHost = computedName) |
Collaborator
There was a problem hiding this comment.
It looks like we're not using ComputedNameWithHost today, though it's something we could do. Could you make this mirror InitDisplayName and show computedName (HostName) https://github.com/tailscale/tailscale/blob/main/tailcfg/tailcfg.go#L615 ?
bradfitz
force-pushed
the
bradfitz/rm_netmap
branch
from
752d39e to
1d60693
Compare
Member
Author
|
just fixed some problems around account switching back & forth between accounts where the previous version was retaining nodes in the display list (not in Go in wireguard) from the old account. seems to all work in the latest version now |
Follow up to tailscale/tailscale#19607, which introduced the constant-time node add/remove path and temporarily kept Android on legacy Notify.NetMap emission. Move the Android app notification watcher to InitialStatus plus peer-change notifications, and opt both Android watchers out of runtime NetMap delivery. Updates tailscale/tailscale#12542 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz
force-pushed
the
bradfitz/rm_netmap
branch
from
1d60693 to
2907cce
Compare
Member
Author
|
(merging per Slack chat w/ @kari-ts) |
kari-ts
reviewed
May 27, 2026
| } | ||
|
|
||
| val self = notify.SelfChange | ||
| if (initial == null && self != null && !next.isSameSelf(self)) { |
Collaborator
There was a problem hiding this comment.
do we need to do userProfiles.clear() here too?
This was referenced May 27, 2026
bradfitz
added a commit
that referenced
this pull request
May 27, 2026
… profile switch This simplifies #797 now that tailscale/tailscale#19890 is in, addressing #797 (comment) which made me find the WatchIPNBus publishing-side bug. In bumping oss, we also got a new go.toolchain.rev, which made me find missing Makefile dependencies too (the AAR wasn't being rebuilt), so fix that too. Updates tailscale/tailscale#19889 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to tailscale/tailscale#19607, which introduced the
constant-time node add/remove path and temporarily kept Android on
legacy Notify.NetMap emission.
Move the Android app notification watcher to InitialStatus plus
peer-change notifications, and opt both Android watchers out of
runtime NetMap delivery.
Updates tailscale/tailscale#12542