Refactored headerRows usage#167
Open
francisbesset wants to merge 1 commit intotaitems:masterfrom
Open
Conversation
francisbesset
force-pushed
the
fix_headerRows_usage
branch
from
685d5fa to
c2e990a
Compare
Collaborator
|
Hi @francisbesset! I'm going through and cleaning up a bunch of open tickets and PRs, and I'm just now seeing this one—thanks, and sorry for the multi-year delay! 😅 If you're interested in resolving your merge conflicts & rebasing, I'd be glad to merge. I'd also understand if you have completely lost interest in touching such an old branch at this point... (Please let me know if this is the case, and I'd be happy to fix it up myself.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed duplication of code to determine the headerRows value.