Skip to content
This repository was archived by the owner on Dec 18, 2021. It is now read-only.

Use Apple-recommended strategy for locating JAVA_HOME.#14

Merged
mosabua merged 1 commit intotakari:masterfrom
ksperling:java_home
Nov 4, 2016
Merged

Use Apple-recommended strategy for locating JAVA_HOME.#14
mosabua merged 1 commit intotakari:masterfrom
ksperling:java_home

Conversation

@ksperling
Copy link
Copy Markdown

This works correctly with both Oracle and Apple JDKs.
See https://developer.apple.com/library/mac/qa/qa1170/_index.html

@ksperling
Copy link
Copy Markdown
Author

Is anybody still maintaining this repository?

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Apr 7, 2016

Yes... let me try to get to testing and merging this in the next days.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Apr 11, 2016

I tested this and it works nicely. Could you @ksperling sign a Takari CLA and email it to team@takari.io

http://takari.io/support/TakariCLA.pdf

I can then proceed with the merge and work towards a new wrapper/maven plugin release.

fyi @jvanzyl

@metyl
Copy link
Copy Markdown

metyl commented Sep 6, 2016

@ksperling Will You sign Takari CLA to merge this PR?

@ksperling
Copy link
Copy Markdown
Author

Sorry for the slow reply, will send the CLA through tomorrow.

@metyl
Copy link
Copy Markdown

metyl commented Sep 27, 2016

@ksperling Thx for replay, can You rework the PR, there are some conflicts with whitespaces.
@mosabua will You proceed this PR?

This works correctly with both Oracle and Apple JDKs.
@ksperling
Copy link
Copy Markdown
Author

I've emailed the CLA and update the PR

@jvanzyl
Copy link
Copy Markdown

jvanzyl commented Sep 28, 2016

CLA received. All good.

On Sep 27, 2016, at 9:43 PM, Karsten Sperling notifications@github.com wrote:

I've emailed the CLA and update the PR


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks,

Jason


Jason van Zyl
Founder, Takari and Apache Maven
http://twitter.com/jvanzyl

http://twitter.com/takari_io

@metyl
Copy link
Copy Markdown

metyl commented Sep 28, 2016

So can we merge this PR? @mosabua @jvanzyl

@ksperling
Copy link
Copy Markdown
Author

bump?

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Nov 4, 2016

I am merging this .. might want to cut a new release soon @metyl @jvanzyl

@mosabua mosabua merged commit f1ccb97 into takari:master Nov 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants