This repository was archived by the owner on Dec 18, 2021. It is now read-only.
Add "--wrapper-version" argument to show wrapper version#48
Merged
mosabua merged 1 commit intotakari:masterfrom Apr 28, 2017
Merged
Add "--wrapper-version" argument to show wrapper version#48mosabua merged 1 commit intotakari:masterfrom
mosabua merged 1 commit intotakari:masterfrom
Conversation
Member
|
NIce .. will review, test and merge soon. |
Member
|
Thinking about it.. how about instead of just adding another option that no one knows about .. spit out the wrapper version into the log with each invocation.. its one line .. and it would help and no one would need to know any option.. |
Author
|
sounds good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding special handling to
--wrapper-versionargument.Since all maven commands are delegated to plexus launcher, intercept
--wrapper-versionargument, printout wrapper version, then exit the execution before calling plexus launcher.Relates to #44