Skip to content

Commit da3f82d

Browse files
authored
fix: get_all_completed_transactions limit issues (#7267)
Description --- Limit filter was applied twice: 1. when fetching completed and cancelled transactions, we use limit for both 2 We apply offset and limit filter on merged records, which means: offset 20, limit 20. returns 0 records <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Resolved an issue where completed and cancelled transactions were not fully retrieved due to an unintended limit. All relevant transactions are now fetched as expected. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent d3676ef commit da3f82d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

applications/minotari_console_wallet/src/grpc/wallet_grpc_server.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1324,7 +1324,7 @@ impl wallet_server::Wallet for WalletGrpcServer {
13241324
let mut transaction_service = self.get_transaction_service();
13251325

13261326
let mut completed_transactions = transaction_service
1327-
.get_completed_transactions(None, None, None, req.limit)
1327+
.get_completed_transactions(None, None, None, 0)
13281328
.await
13291329
.map_err(|err| {
13301330
Status::not_found(format!(
@@ -1334,7 +1334,7 @@ impl wallet_server::Wallet for WalletGrpcServer {
13341334
})?;
13351335
completed_transactions.extend(
13361336
transaction_service
1337-
.get_cancelled_completed_transactions(req.limit)
1337+
.get_cancelled_completed_transactions(0)
13381338
.await
13391339
.map_err(|err| {
13401340
Status::not_found(format!(

0 commit comments

Comments
 (0)