Seedstrap is failing

[SWvheerden]

Peer manager does not seem to be able to get seed peers:

2025-09-03 13:35:24.875635000 [p2p::initialization] [Thread:252521] DEBUG Adding seed peer [PeerFlags(SEED)[ab2fad12f4486284] PK=4cdfb70e0b38b60c6a3573b2870e32bc3d846419c606ea379f43650b80f38409 (/ip4/51.83.4.85/tcp/18189) - . Type: BASE_NODE. User agent: <unknown>.] // base_layer/p2p/src/initialization.rs:413
2025-09-03 13:35:24.878015000 [p2p::initialization] [Thread:252521] DEBUG Adding seed peer [PeerFlags(SEED)[ace05844c9c9723a] PK=1e08628960f75b7e324f010b2ee609a9e28097e9101f4d769d474a38b6ee2d76 (/ip4/51.83.102.25/tcp/18189) - . Type: BASE_NODE. User agent: <unknown>.] // base_layer/p2p/src/initialization.rs:413
2025-09-03 13:35:24.878549000 [p2p::initialization] [Thread:252521] DEBUG Adding seed peer [PeerFlags(SEED)[ace05844c9c9723a] PK=1e08628960f75b7e324f010b2ee609a9e28097e9101f4d769d474a38b6ee2d76 (/ip6/2001:41d0:303:a619::1/tcp/18189) - . Type: BASE_NODE. User agent: <unknown>.] // base_layer/p2p/src/initialization.rs:413
2025-09-03 13:35:24.879499000 [p2p::initialization] [Thread:252521] DEBUG Adding seed peer [PeerFlags(SEED)[ab2fad12f4486284] PK=4cdfb70e0b38b60c6a3573b2870e32bc3d846419c606ea379f43650b80f38409 (/ip6/2001:41d0:303:9a55::1/tcp/18189) - . Type: BASE_NODE. User agent: <unknown>.] // base_layer/p2p/src/initialization.rs:413
2025-09-03 13:35:24.879781000 [p2p::initialization] [Thread:252521] DEBUG Adding seed peer [PeerFlags(SEED)[ace05844c9c9723a] PK=1e08628960f75b7e324f010b2ee609a9e28097e9101f4d769d474a38b6ee2d76 (/onion3/tadnxyokalnqjtvu6mlhxndcq4v2tlolotpvrflscdmi7lcautao3had:18141) - . Type: BASE_NODE. User agent: <unknown>.] // base_layer/p2p/src/initialization.rs:413
2025-09-03 13:35:24.879995000 [p2p::initialization] [Thread:252521] DEBUG Adding seed peer [PeerFlags(SEED)[ab2fad12f4486284] PK=4cdfb70e0b38b60c6a3573b2870e32bc3d846419c606ea379f43650b80f38409 (/onion3/mhfptgpcj6htjkr5zwurom32wvt7x76ovqzn2ttnwo2bnku6baeaaiyd:18141) - . Type: BASE_NODE. User agent: <unknown>.] // base_layer/p2p/src/initialization.rs:413
2025-09-03 13:35:24.880303000 [p2p::initialization] [Thread:252521] DEBUG Adding seed peer [PeerFlags(SEED)[ace05844c9c9723a] PK=1e08628960f75b7e324f010b2ee609a9e28097e9101f4d769d474a38b6ee2d76 (/ip4/51.83.102.25/tcp/18189) - . Type: BASE_NODE. User agent: <unknown>.] // base_layer/p2p/src/initialization.rs:413
WARN  Failed to get seed peers from PeerManager, using empty list // comms/core/src/connectivity/manager.rs:207

This happens from:
#7396

Seed strap does not seem to be able to find any peers from the seed nodes:

13:17 WARN  SeedStrap: Failed to contact any seed nodes or retrieve new peers.
13:17 WARN  SeedStrap round was not successful. Waiting before next attempt.

This happens from: #7303

[hansieodendaal]

The first warning message WARN Failed to get seed peers from PeerManager, using empty list // comms/core/src/connectivity/manager.rs:207 is a timing issue. In this context the seed peer list is passed to the proactive dialer to exclude them from being proactively dialed if other connections exist. On a node with proper connectivity, seed peer dial requests are coming through straight after.

• 2025-09-04 16:28:05.638210600 [p2p::initialization] DEBUG Adding seed peer [PeerFlags(SEED)[0984896e74022c44]
• 2025-09-04 16:28:05.648016500 [comms::connectivity::manager] DEBUG ConnectivityManager started
• 2025-09-04 16:28:05.648239900 [comms::connectivity::manager] WARN Failed to get seed peers from PeerManager, using empty list
• 2025-09-04 16:28:05.648850400 [comms::dht::connectivity] DEBUG Adding 5 neighbouring peer(s), removing 0 peers: 0984896e74022c442c1034852c,
• 2025-09-04 16:28:05.648912900 [comms::connectivity::manager] TRACE Request (11267568784269984977): DialPeer { node_id: NodeId(0984896e74022c442c1034852c), reply_tx: None }
  ...
• 2025-09-04 16:31:05.655859300 [comms::connectivity::manager] DEBUG (5619097807157888458) Starting proactive dialing execution - current connections: 10, target: 8

To alleviate this false negative, I will make a PR to move requesting the peer list in the comms::connectivity::manager to be just in time when the proactive dialer is started.

Update: Ok, that fix still fires the warning message, odd, looking into it further.

Update: The PR #7474 now gives the proper results.

[hansieodendaal]

I could not replicate the 2nd error: 13:17 WARN SeedStrap: Failed to contact any seed nodes or retrieve new peers. at all, on mainnet or esmeralda, starting with a brand new base node or one that has been synced, with or without a peer_db, with or without a current node_id.

[hansieodendaal]

The real issue here has been tracked to the esmeralda seed nodes not providing their peer lists in some cases when connecting to base nodes. This phenomena has been replicated locally.

Next steps are to analyze the local log files and look into the esmeralda seed peers.

[hansieodendaal]

It seems the query logic with multi_addresses_with_stats does not give us what we expect, specifically the last_failed_reason is not cleared with active connections.