chore(ci): build docker with metrics#6916
chore(ci): build docker with metrics#6916SWvheerden merged 2 commits intotari-project:developmentfrom ns212:ci-docker
Conversation
WalkthroughThe changes update two configuration files. In the GitHub Actions workflow YAML, the default value of the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
buildtools/docker_rig/tarilabs.Dockerfile (1)
124-125: Verify the addition of thetinipackage.
The addition oftiniin the list of packages is a good move for handling process reaping and signal forwarding in the container. Please ensure that the default version shipped with the OS base (Bookworm) meets your requirements. If version consistency is a concern, consider pinning the package version..github/workflows/build_dockers_workflow.yml (1)
21-24: Confirm the updated default value for thefeaturesinput parameter.
The default value has been updated from'safe,grpc'to'safe,libtor,metrics', reflecting the removal of unused feature flags and the addition of metrics support. Please verify that this change is aligned with the overall feature set and that any documentation or dependent configurations have been updated accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/build_dockers_workflow.yml(1 hunks)buildtools/docker_rig/tarilabs.Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: test (mainnet, stagenet)
- GitHub Check: test (nextnet, nextnet)
- GitHub Check: test (testnet, esmeralda)
- GitHub Check: ci
- GitHub Check: cargo check with stable
- GitHub Check: Cucumber tests / Base Layer
- GitHub Check: Cucumber tests / FFI
Test Results (CI) 3 files 129 suites 44m 52s ⏱️ Results for commit 917bd05. ♻️ This comment has been updated with latest results. |
| features: | ||
| type: string | ||
| default: 'safe,grpc' | ||
| default: 'safe,libtor,metrics' |
There was a problem hiding this comment.
Should we not keep grpc?
libtor is the default for nix, but having it in seems more clear.
There was a problem hiding this comment.
I think we do need grpc for the block explorers
There was a problem hiding this comment.
I removed it because I don't see grpc defined as a feature flag anymore
There was a problem hiding this comment.
what are we building here?
I see the base node only has has grpc as a config option not compile feature
There was a problem hiding this comment.
Docker images for tari_suite.
Console wallet has the empty feature too. Was it not meant as a none default build feature?
There was a problem hiding this comment.
I did local build with and without grpc feature, and my base node still started up, so I think this can go in.
SWvheerden
changed the title
* development: fix(p2p/dns): greatly simplify DNS TXT lookup (tari-project#6922) feat: handle outbound pipeline interlock due to connection cleanup (tari-project#6921) chore(ci): build docker with metrics (tari-project#6916)
* development: fix(p2p/dns): greatly simplify DNS TXT lookup (tari-project#6922) feat: handle outbound pipeline interlock due to connection cleanup (tari-project#6921) chore(ci): build docker with metrics (tari-project#6916)
* development: fix(p2p/dns): greatly simplify DNS TXT lookup (tari-project#6922) feat: handle outbound pipeline interlock due to connection cleanup (tari-project#6921) chore(ci): build docker with metrics (tari-project#6916)
* development: fix(p2p/dns): greatly simplify DNS TXT lookup (tari-project#6922) feat: handle outbound pipeline interlock due to connection cleanup (tari-project#6921) chore(ci): build docker with metrics (tari-project#6916)
* development: fix(p2p/dns): greatly simplify DNS TXT lookup (tari-project#6922) feat: handle outbound pipeline interlock due to connection cleanup (tari-project#6921) chore(ci): build docker with metrics (tari-project#6916)
3 participants
Description
Build minotari_node with metrics feature enabled; Remove unused feature flags;
Motivation and Context
How Has This Been Tested?
Tested on a seed node.
What process can a PR reviewer use to test or verify this change?
Breaking Changes
Summary by CodeRabbit