Skip to content

chore: new release v1.13.3-pre.0#6919

Merged
SWvheerden merged 1 commit intotari-project:developmentfrom
SWvheerden:sw_new_release
Apr 3, 2025
Merged

chore: new release v1.13.3-pre.0#6919
SWvheerden merged 1 commit intotari-project:developmentfrom
SWvheerden:sw_new_release

Conversation

@SWvheerden
Copy link
Copy Markdown
Collaborator

@SWvheerden SWvheerden commented Apr 3, 2025

Description

new release esme

Summary by CodeRabbit

  • Chores
    • Incremented version numbers to 1.13.3-pre.0 across multiple components.
  • Documentation
    • Updated recommended network versions in the user documentation.
  • New Features
    • Enhanced transaction handling for one-sided payments with improved validation and metadata support.
  • Bug Fixes
    • Fixed a migration issue to improve system stability.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2025

Walkthrough

This pull request primarily bumps the pre-release version from "1.13.2-pre.0" to "1.13.3-pre.0" across multiple Cargo.toml files in various packages and components. The README has been updated with revised recommended running versions for the Nextnet and Esmeralda networks. Additionally, changelog files include a migration fix and new method declarations related to one-sided transaction handling. The supply-chain configuration is also updated to reflect the new version numbers for several exemptions.

Changes

File(s) Change Summary
Cargo.toml, applications/minotari_ledger_wallet/{comms, wallet}/Cargo.toml, applications/minotari_miner/Cargo.toml, base_layer/contacts/src/chat_client/Cargo.toml, comms/rpc_macros/Cargo.toml, infrastructure/test_utils/Cargo.toml Bumped package versions from "1.13.2-pre.0" to "1.13.3-pre.0".
README.md Updated recommended running versions: Nextnet from "1.13.2-rc.0" to "1.13.3-rc.0" and Esmeralda from "1.13.2-pre.0" to "1.13.3-pre.0".
changelog-development.md Added a fix for migration 5 with the new method fix_migration_5(block_hash) and included minor bug fixes.
changelog-nextnet.md, wallet_ffi.h Introduced enhancements for one-sided transaction handling, including new methods (wallet_get_utxos(), wallet_coin_join(), wallet_coin_split(), commitment_signature_create(), commitment_signature_destroy()) and an updated signature for wallet_import_utxo().
supply-chain/config.toml Updated version numbers in the exemptions section from "1.13.2-pre.0" to "1.13.3-pre.0" for multiple entries.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant TariWallet
  participant ChainService

  User->>TariWallet: Initiate one-sided payment request
  TariWallet->>TariWallet: Execute wallet_get_utxos()
  TariWallet->>TariWallet: Process wallet_coin_join()/wallet_coin_split()
  TariWallet->>ChainService: Validate transaction details
  ChainService-->>TariWallet: Return validation result
  TariWallet->>User: Callback with transaction status
Loading

Possibly related PRs

Suggested reviewers

  • hansieodendaal
  • stringhandler

Poem

I'm a bunny with a carrot code treat,
Hopping through Cargo files with a version bump beat.
From one pre-release to a slightly newer bite,
Changelogs twinkle with fixes shining bright.
I nibble on updates with whisker delight,
Celebrating new hops in the code tonight!
(_/)( •_•)( >🥕)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73a91d3 and 5dbfde6.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (11)
  • Cargo.toml (1 hunks)
  • README.md (1 hunks)
  • applications/minotari_ledger_wallet/comms/Cargo.toml (1 hunks)
  • applications/minotari_ledger_wallet/wallet/Cargo.toml (1 hunks)
  • applications/minotari_miner/Cargo.toml (1 hunks)
  • base_layer/contacts/src/chat_client/Cargo.toml (1 hunks)
  • changelog-development.md (1 hunks)
  • changelog-nextnet.md (1 hunks)
  • comms/rpc_macros/Cargo.toml (1 hunks)
  • infrastructure/test_utils/Cargo.toml (1 hunks)
  • supply-chain/config.toml (2 hunks)
👮 Files not reviewed due to content moderation or server errors (2)
  • changelog-development.md
  • changelog-nextnet.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
changelog-development.md

5-5: Heading levels should only increment by one level at a time
Expected: h2; Actual: h3

(MD001, heading-increment)

changelog-nextnet.md

23-23: Multiple headings with the same content
null

(MD024, no-duplicate-heading)


27-27: Multiple headings with the same content
null

(MD024, no-duplicate-heading)


30-30: Multiple headings with the same content
null

(MD024, no-duplicate-heading)

⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: test (testnet, esmeralda)
  • GitHub Check: test (nextnet, nextnet)
  • GitHub Check: ci
  • GitHub Check: cargo check with stable
  • GitHub Check: Cucumber tests / FFI
  • GitHub Check: Cucumber tests / Base Layer
🔇 Additional comments (10)
README.md (1)

26-27: Bump version numbers for network recommendations.
The updated versions for Nextnet (1.13.3-rc.0) and Esmeralda (1.13.3-pre.0) correctly reflect the new release requirements. Please double-check that these version numbers are consistent with changes in related configuration files (e.g., in Cargo.toml) and in any other documentation referencing these networks.

applications/minotari_ledger_wallet/comms/Cargo.toml (1)

3-3: Version bump applied correctly.
The package version is updated to "1.13.3-pre.0" in line 3, which aligns with the coordinated version bump across the project.

base_layer/contacts/src/chat_client/Cargo.toml (1)

6-6: Version update verified.
The change on line 6 updates the version to "1.13.3-pre.0", ensuring consistency with the other components updated in this release.

infrastructure/test_utils/Cargo.toml (1)

4-4: Consistent version bump.
The version in line 4 is updated to "1.13.3-pre.0", which is consistent with the overall project release strategy, and no issues are present.

comms/rpc_macros/Cargo.toml (1)

9-9: Proper synchronization of versioning.
The version on line 9 has been updated to "1.13.3-pre.0", which aligns with the coordinated version bump across multiple Cargo.toml files.

applications/minotari_ledger_wallet/wallet/Cargo.toml (1)

3-3: Version update is on point.
The updated version on line 3 to "1.13.3-pre.0" maintains consistency with the rest of the project’s pre-release updates.

Cargo.toml (1)

1-2: Version Bump Updated in Workspace Package
The version number in the [workspace.package] section has been correctly updated to "1.13.3-pre.0". This ensures consistency with the intended release.

applications/minotari_miner/Cargo.toml (1)

1-8: Updated Miner Package Version
The version field has been bumped to "1.13.3-pre.0", aligning this package with the new release. Please confirm that consumers of the minotari_miner package are aware of this update.

supply-chain/config.toml (2)

1255-1289: Exemption Version Bump Consistency Check (Part 1)
The exemption entries for several packages—such as minotari_app_grpc, minotari_app_utilities, minotari_chat_ffi, minotari_console_wallet, minotari_merge_mining_proxy, minotari_miner, minotari_mining_helper_ffi, minotari_wallet, and minotari_wallet_ffi—have been updated to "1.13.3-pre.0". This update aligns the supply-chain configuration with the new release version.


2043-2125: Exemption Version Bump Consistency Check (Part 2)
For core Tari packages—namely tari_common, tari_common_sqlite, tari_common_types, tari_comms, tari_comms_dht, tari_comms_rpc_macros, tari_contacts, tari_core, tari_features, tari_hashing, tari_key_manager, tari_libtor, tari_metrics, tari_mmr, tari_p2p, tari_script, tari_service_framework, tari_shutdown, tari_storage, and tari_test_utils—the version has been uniformly updated to "1.13.3-pre.0". This systematic version bump reinforces consistency across the supply chain configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2025

Test Results (CI)

    3 files    129 suites   43m 20s ⏱️
1 353 tests 1 353 ✅ 0 💤 0 ❌
4 057 runs  4 057 ✅ 0 💤 0 ❌

Results for commit 5dbfde6.

@SWvheerden SWvheerden merged commit cef46a5 into tari-project:development Apr 3, 2025
16 of 17 checks passed
sdbondi added a commit to sdbondi/tari that referenced this pull request Apr 3, 2025
* development:
  chore: new release v1.13.3-pre.0 (tari-project#6919)
  fix: fix migration 5 (tari-project#6915)
  chore: update change logs (tari-project#6913)
  chore: new release v1.13.2-pre.0 (tari-project#6912)
  fix: randomX seed management (tari-project#6910)
  fix(comms/yamux): dont poll the substream after closing/error (tari-project#6911)
  fix: dont poll yamux substream after an error (tari-project#6909)
  feat: remove memory allocation for max_size_vec (tari-project#6903)
  feat: add display info to yamux (tari-project#6904)
@coderabbitai coderabbitai bot mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants