feat: add getCompleteAddress to GRPC#6969
feat: add getCompleteAddress to GRPC#6969stringhandler merged 2 commits intotari-project:developmentfrom
Conversation
|
""" WalkthroughA new gRPC method, Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant WalletGrpcServer
participant Wallet
Client->>WalletGrpcServer: GetCompleteAddress (Empty)
WalletGrpcServer->>Wallet: get_interactive_address()
WalletGrpcServer->>Wallet: get_one_sided_address()
WalletGrpcServer->>WalletGrpcServer: Format addresses (binary, Base58, emoji)
WalletGrpcServer-->>Client: GetCompleteAddressResponse (all formats)
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Test Results (CI) 3 files 129 suites 55m 57s ⏱️ Results for commit 53997e9. |
Test Results (Integration tests) 2 files + 2 11 suites +11 1h 27m 56s ⏱️ + 1h 27m 56s For more details on these failures, see this check. Results for commit 53997e9. ± Comparison against base commit 6951379. |
Description
Adds getCompleteAddress to the wallet GRPC interface which returns a complete set of address data:
Motivation and Context
Using the GRPC interface to extract address information required a lot of post-processing to get the same values that are presented in the console wallet.
How Has This Been Tested?
I ran the the wallet with grpc enabled and extracted the address and compared it to the console wallet.
What process can a PR reviewer use to test or verify this change?
Run the console wallet with grpc enabled and request the getCompleteAddress rpc endpoint.
Breaking Changes
Summary by CodeRabbit