fix: don't recalc smt on height change

[stringhandler]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling during block validation and MMR root calculations, providing clearer warnings and distinguishing expected errors from unexpected ones.
  • Enhanced logging for specific error cases to help users better understand validation failures.

[coderabbitai]

Walkthrough

The changes refine error handling in the calculation of Merkle Mountain Range (MMR) roots within the blockchain database and block body validation components. Specifically, the code now explicitly detects the ChainStorageError::CannotCalculateNonTipMmr error, logs a targeted warning, and returns the error immediately without resetting the Sparse Merkle Tree (SMT). For other errors, the previous behavior is maintained: a warning is logged, the SMT is reset, and the error is returned. Additionally, error logging is enhanced in the block body validator to provide more context when failures occur.

Changes

File(s)	Change Summary
base_layer/core/src/chain_storage/blockchain_database.rs	Refined error handling for MMR root calculations by distinguishing CannotCalculateNonTipMmr from other errors.
base_layer/core/src/validation/block_body/block_body_full_validator.rs	Enhanced error handling and logging for MMR root calculation errors in block validation, with explicit error matching.

Poem

A bunny hopped through blockchain code,
Where MMR roots and errors flowed.
Now errors known are gently caught,
With warnings clear and resets not.
For only the strange, the tree resets,
But known mistakes bring no regrets.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a001fb0 and 74c2108.

📒 Files selected for processing (2)

• base_layer/core/src/chain_storage/blockchain_database.rs (2 hunks)
• base_layer/core/src/validation/block_body/block_body_full_validator.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• base_layer/core/src/validation/block_body/block_body_full_validator.rs
• base_layer/core/src/chain_storage/blockchain_database.rs

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: ci

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Test Results (CI)

    3 files    129 suites   46m 14s ⏱️
1 335 tests 1 334 ✅ 0 💤 1 ❌
4 003 runs  4 002 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit a001fb0.

[github-actions]

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   1h 58m 7s ⏱️ + 1h 58m 7s
36 tests +36  31 ✅ +31  0 💤 ±0   5 ❌ + 5 
46 runs  +46  32 ✅ +32  0 💤 ±0  14 ❌ +14 

For more details on these failures, see this check.

Results for commit a001fb0. ± Comparison against base commit 6951379.