Skip to content

feat!: remove the ability to send completely raw bytes via grpc #7117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SWvheerden merged 3 commits into from
May 29, 2025
Merged

feat!: remove the ability to send completely raw bytes via grpc #7117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8846fa5
remove the ability to send completely raw bytes
SWvheerden May 28, 2025
0e9e91a
add transaction info, add commitments from the transaction
SWvheerden May 28, 2025
fa2a809
clippy
SWvheerden May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions applications/minotari_app_grpc/proto/wallet.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,6 +1151,7 @@ message TransferResult {
uint64 transaction_id = 2;
bool is_success = 3;
string failure_message = 4;
TransactionInfo transaction_info = 5;
}

message ClaimShaAtomicSwapRequest{
Expand Down Expand Up @@ -1194,6 +1195,8 @@ message TransactionInfo {
bytes raw_payment_id = 12;
uint64 mined_in_block_height = 13;
bytes user_payment_id = 14;
repeated bytes input_commitments = 15;
repeated bytes output_commitments = 16;
}

enum TransactionDirection {
Expand Down
Loading
Loading
⚡