Skip to content

chore: new release v4.1.0-pre.0#7132

Merged
SWvheerden merged 1 commit intotari-project:developmentfrom
SWvheerden:sw_newrelease
May 30, 2025
Merged

chore: new release v4.1.0-pre.0#7132
SWvheerden merged 1 commit intotari-project:developmentfrom
SWvheerden:sw_newrelease

Conversation

@SWvheerden
Copy link
Copy Markdown
Collaborator

@SWvheerden SWvheerden commented May 30, 2025

Description

new esme release

Summary by CodeRabbit

  • New Features

    • Introduced a base node HTTP wallet service.
    • Added a SQLite peer database.
    • Enabled pagination for retrieving all completed transactions.
    • Implemented a new bootstrap process.
  • Bug Fixes

    • Improved DNS fallback with hardcoded Esmeralda seeds.
    • Excluded coinbase transactions from fee calculations.
    • Fixed FFI Tari address parsing from emoji.
    • Resolved mismatched TMS database state.
    • Enhanced peer retention and connection handling.
  • Breaking Changes

    • Removed the ability to send completely raw bytes via gRPC.
  • Documentation

    • Updated recommended network versions and changelogs for the latest release.
  • Chores

    • Updated package and exemption versions to 4.1.0-pre.0 across the project.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 30, 2025

Walkthrough

This update increments version numbers from 4.0.0-pre.0 (and 3.0.0-pre.2 in some cases) to 4.1.0-pre.0 across multiple Cargo.toml files, configuration entries, and documentation. Changelog files for Mainnet, Nextnet, and development were updated with release notes for version 4.1.0, detailing new features, breaking changes, and bug fixes.

Changes

File(s) Change Summary
Cargo.toml, applications/minotari_ledger_wallet/comms/Cargo.toml, applications/minotari_ledger_wallet/wallet/Cargo.toml, applications/minotari_miner/Cargo.toml, comms/rpc_macros/Cargo.toml, infrastructure/test_utils/Cargo.toml Updated package version numbers from 4.0.0-pre.0 (and 3.0.0-pre.2) to 4.1.0-pre.0.
supply-chain/config.toml Updated all exemption version numbers from 3.0.0-pre.2/4.0.0-pre.0 to 4.1.0-pre.0; no other changes.
README.md Updated recommended Tari network versions to 4.1.0, 4.1.0-rc.0, and 4.1.0-pre.0.
changelog-Mainnet.md, changelog-nextnet.md, changelog-development.md Added release notes for version 4.1.0, listing breaking changes, new features, and bug fixes.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Cargo.toml
    participant Config.toml
    participant README.md
    participant Changelog

    Developer->>Cargo.toml: Update version to 4.1.0-pre.0
    Developer->>Config.toml: Update exemption versions to 4.1.0-pre.0
    Developer->>README.md: Update recommended network versions
    Developer->>Changelog: Add 4.1.0 release notes
Loading

Possibly related PRs

Suggested reviewers

  • hansieodendaal

Poem

Oh, what a hop to version four-point-one,
With numbers aligned, the update is done!
Changelogs now sparkle, new features to see,
The networks refreshed, as smooth as can be.
🐇✨
A rabbit’s delight in a versioning spree!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (2)
changelog-development.md (2)

10-10: Use proper casing for gRPC.
"grpc" should be written as "gRPC" to reflect the official name of the protocol.

Apply this diff:

- * remove the ability to send completely raw bytes via grpc (#7117)
+ * remove the ability to send completely raw bytes via gRPC (#7117)

23-26: Normalize acronym casing in Bug Fixes.
Standardize acronyms for consistency and readability:

  • "esme" → "Esme"
  • "dns" → "DNS"
  • "ffi" → "FFI"
  • "tms db" → "TMS DB"
- * add hardcoded esme seeds for dns fallback ([#7120](https://github.com/tari-project/tari/issues/7120)) ([0fd2442](https://github.com/tari-project/tari/commit/0fd2442d59d79e5ef4321508e74822edb8674be5))
+ * add hardcoded Esme seeds for DNS fallback ([#7120](https://github.com/tari-project/tari/issues/7120)) ([0fd2442](https://github.com/tari-project/tari/commit/0fd2442d59d79e5ef4321508e74822edb8674be5))
- * ffi tari address from emoji ([#7114](https://github.com/tari-project/tari/issues/7114)) ([8c97103](https://github.com/tari-project/tari/commit/8c971034327058cd37c5b0bc60185f3e890b5f05))
+ * FFI Tari address from emoji ([#7114](https://github.com/tari-project/tari/issues/7114)) ([8c97103](https://github.com/tari-project/tari/commit/8c971034327058cd37c5b0bc60185f3e890b5f05))
- * mismatched tms db state ([#7131](https://github.com/tari-project/tari/issues/7131)) ([9e9b8b6](https://github.com/tari-project/tari/commit/9e9b8b620870eecb1063cebfa7e5057ed7092d2b))
+ * mismatched TMS DB state ([#7131](https://github.com/tari-project/tari/issues/7131)) ([9e9b8b6](https://github.com/tari-project/tari/commit/9e9b8b620870eecb1063cebfa7e5057ed7092d2b))
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e9b8b6 and c301378.

⛔ Files ignored due to path filters (4)
  • Cargo.lock is excluded by !**/*.lock
  • applications/minotari_ledger_wallet/wallet/Cargo.lock is excluded by !**/*.lock
  • clients/ffi_client/package-lock.json is excluded by !**/package-lock.json
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (11)
  • Cargo.toml (1 hunks)
  • README.md (1 hunks)
  • applications/minotari_ledger_wallet/comms/Cargo.toml (1 hunks)
  • applications/minotari_ledger_wallet/wallet/Cargo.toml (1 hunks)
  • applications/minotari_miner/Cargo.toml (1 hunks)
  • changelog-Mainnet.md (1 hunks)
  • changelog-development.md (1 hunks)
  • changelog-nextnet.md (1 hunks)
  • comms/rpc_macros/Cargo.toml (1 hunks)
  • infrastructure/test_utils/Cargo.toml (1 hunks)
  • supply-chain/config.toml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: cargo check with stable
  • GitHub Check: test (mainnet, stagenet)
  • GitHub Check: test (nextnet, nextnet)
  • GitHub Check: test (testnet, esmeralda)
  • GitHub Check: ci
  • GitHub Check: Cucumber tests / FFI
  • GitHub Check: Cucumber tests / Base Layer
🔇 Additional comments (12)
infrastructure/test_utils/Cargo.toml (1)

4-4: Approve version bump for tari_test_utils.

The version field has been correctly updated from 4.0.0-pre.0 to 4.1.0-pre.0, aligning with the intended pre-release. No other manifest fields were modified, and dependencies remain unchanged.

applications/minotari_ledger_wallet/wallet/Cargo.toml (1)

3-3: Approve version bump for minotari_ledger_wallet.

The crate version has been updated to 4.1.0-pre.0 to match the workspace release. Dependencies and metadata are consistent.

comms/rpc_macros/Cargo.toml (1)

9-9: Approve version bump for tari_comms_rpc_macros.

The version field is now 4.1.0-pre.0, in sync with the new release. No changes to dependencies or configuration.

applications/minotari_ledger_wallet/comms/Cargo.toml (1)

3-3: Approve version bump for minotari_ledger_wallet_comms.

Updated the crate version to 4.1.0-pre.0 in line with the coordinated release. Manifest structure remains correct.

Cargo.toml (1)

2-2: Approve workspace version bump.

The workspace package version has been correctly bumped to 4.1.0-pre.0 to reflect the new pre-release. Members and dependencies lists remain consistent.

README.md (1)

25-27: Update recommended network versions to 4.1.0-pre.0 release
The table entries for Mainnet, Nextnet, and Esmeralda have been correctly bumped to 4.1.0, 4.1.0-rc.0, and 4.1.0-pre.0 respectively, matching the new release cycle.

applications/minotari_miner/Cargo.toml (1)

7-7: Bump crate version to 4.1.0-pre.0
The version field has been updated from 4.0.0-pre.0 to 4.1.0-pre.0, aligning with the workspace-wide release bump.

changelog-nextnet.md (2)

5-6: Changelog entry for 4.1.0-rc.0 is correctly added
The new section header with link and date follows the conventional-changelog format.


21-28: Bug fixes section looks solid
All bug fix items are clear, include issue references and commit hashes, and align with the release notes format.

supply-chain/config.toml (2)

1575-1630: Exemption entries for Minotari components version bump
All [[exemptions.minotari_*]] entries have been consistently updated to version "4.1.0-pre.0" (both duplicates), matching the new pre-release.


2675-2830: Exemption entries for Tari crates version bump
All [[exemptions.tari_*]] entries have been correctly updated to version "4.1.0-pre.0", in line with the workspace and manifest updates.

changelog-development.md (1)

5-6: Version header updated correctly.
The entry for version 4.1.0-pre.0 with the correct compare link and date is in place.

Comment on lines +8 to +18
### ⚠ BREAKING CHANGES

* remove the ability to send completely raw bytes via grpc (#7117)

### Features

* add base node HTTP wallet service ([#7061](https://github.com/tari-project/tari/issues/7061)) ([1382008](https://github.com/tari-project/tari/commit/1382008771037e11e3c9c8bdeb71f5aa198e9e21))
* add sqlite peer_db ([#6963](https://github.com/tari-project/tari/issues/6963)) ([0f1b0dc](https://github.com/tari-project/tari/commit/0f1b0dc386462529512676d177c6316ece8bd20e))
* get all completed txs with pagination ([#7113](https://github.com/tari-project/tari/issues/7113)) ([d292cec](https://github.com/tari-project/tari/commit/d292cecd4c95870947831129f9b476f73bf8ea59))
* new bootstrap process ([#7121](https://github.com/tari-project/tari/issues/7121)) ([e5a0854](https://github.com/tari-project/tari/commit/e5a08540b30084d566a1cfb99336797f50a65b3e))
* remove the ability to send completely raw bytes via grpc ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac28](https://github.com/tari-project/tari/commit/1e7ac281ad7a20f45c6852f131ea44db246f4f72))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove duplicate "raw bytes via gRPC" entry & unify formatting
The breaking change "* remove the ability to send completely raw bytes via grpc (#7117)" is duplicated in the Features section. Consolidate it under Breaking Changes only, include the issue link and commit hash there, and remove the second occurrence (line 18). Also standardize "gRPC" capitalization.

@@ ### ⚠ BREAKING CHANGES
-* remove the ability to send completely raw bytes via grpc (#7117)
+* remove the ability to send completely raw bytes via gRPC ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac281ad7a20f45c6852f131ea44db246f4f72])
@@ ### Features
- * remove the ability to send completely raw bytes via grpc ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac281ad7a20f45c6852f131ea44db246f4f72])
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### ⚠ BREAKING CHANGES
* remove the ability to send completely raw bytes via grpc (#7117)
### Features
* add base node HTTP wallet service ([#7061](https://github.com/tari-project/tari/issues/7061)) ([1382008](https://github.com/tari-project/tari/commit/1382008771037e11e3c9c8bdeb71f5aa198e9e21))
* add sqlite peer_db ([#6963](https://github.com/tari-project/tari/issues/6963)) ([0f1b0dc](https://github.com/tari-project/tari/commit/0f1b0dc386462529512676d177c6316ece8bd20e))
* get all completed txs with pagination ([#7113](https://github.com/tari-project/tari/issues/7113)) ([d292cec](https://github.com/tari-project/tari/commit/d292cecd4c95870947831129f9b476f73bf8ea59))
* new bootstrap process ([#7121](https://github.com/tari-project/tari/issues/7121)) ([e5a0854](https://github.com/tari-project/tari/commit/e5a08540b30084d566a1cfb99336797f50a65b3e))
* remove the ability to send completely raw bytes via grpc ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac28](https://github.com/tari-project/tari/commit/1e7ac281ad7a20f45c6852f131ea44db246f4f72))
### ⚠ BREAKING CHANGES
* remove the ability to send completely raw bytes via gRPC ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac281ad7a20f45c6852f131ea44db246f4f72])
### Features
* add base node HTTP wallet service ([#7061](https://github.com/tari-project/tari/issues/7061)) ([1382008](https://github.com/tari-project/tari/commit/1382008771037e11e3c9c8bdeb71f5aa198e9e21))
* add sqlite peer_db ([#6963](https://github.com/tari-project/tari/issues/6963)) ([0f1b0dc](https://github.com/tari-project/tari/commit/0f1b0dc386462529512676d177c6316ece8bd20e))
* get all completed txs with pagination ([#7113](https://github.com/tari-project/tari/issues/7113)) ([d292cec](https://github.com/tari-project/tari/commit/d292cecd4c95870947831129f9b476f73bf8ea59))
* new bootstrap process ([#7121](https://github.com/tari-project/tari/issues/7121)) ([e5a0854](https://github.com/tari-project/tari/commit/e5a08540b30084d566a1cfb99336797f50a65b3e))
🤖 Prompt for AI Agents
In changelog-nextnet.md lines 8 to 18, remove the duplicate entry about removing
the ability to send raw bytes via gRPC from the Features section (line 18). Keep
this change only under the Breaking Changes section, ensuring it includes the
issue link and commit hash. Also, standardize the capitalization of "gRPC"
throughout the changelog for consistency.

* add sqlite peer_db ([#6963](https://github.com/tari-project/tari/issues/6963)) ([0f1b0dc](https://github.com/tari-project/tari/commit/0f1b0dc386462529512676d177c6316ece8bd20e))
* get all completed txs with pagination ([#7113](https://github.com/tari-project/tari/issues/7113)) ([d292cec](https://github.com/tari-project/tari/commit/d292cecd4c95870947831129f9b476f73bf8ea59))
* new bootstrap process ([#7121](https://github.com/tari-project/tari/issues/7121)) ([e5a0854](https://github.com/tari-project/tari/commit/e5a08540b30084d566a1cfb99336797f50a65b3e))
* remove the ability to send completely raw bytes via grpc ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac28](https://github.com/tari-project/tari/commit/1e7ac281ad7a20f45c6852f131ea44db246f4f72))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate entry in Features section.
The breaking change "remove the ability to send completely raw bytes via grpc" is already listed under Breaking Changes and should not be repeated under Features.

Consider deleting this line:

- * remove the ability to send completely raw bytes via grpc ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac28](https://github.com/tari-project/tari/commit/1e7ac281ad7a20f45c6852f131ea44db246f4f72))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* remove the ability to send completely raw bytes via grpc ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac28](https://github.com/tari-project/tari/commit/1e7ac281ad7a20f45c6852f131ea44db246f4f72))
🤖 Prompt for AI Agents
In changelog-development.md at line 18, there is a duplicate entry for the
breaking change "remove the ability to send completely raw bytes via grpc"
listed under the Features section. Remove this line entirely to avoid redundancy
since it is already documented under Breaking Changes.


All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [4.1.0](https://github.com/tari-project/tari/compare/v4.0.0...v4.1.0) (2025-05-30)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Mismatch between PR version and changelog header.

The PR is introducing the 4.1.0-pre.0 release, but the changelog uses 4.1.0. Please update the header to reflect the pre-release version and adjust the compare link accordingly:

- ## [4.1.0](https://github.com/tari-project/tari/compare/v4.0.0...v4.1.0) (2025-05-30)
+ ## [4.1.0-pre.0](https://github.com/tari-project/tari/compare/v4.0.0-pre.0...v4.1.0-pre.0) (2025-05-30)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## [4.1.0](https://github.com/tari-project/tari/compare/v4.0.0...v4.1.0) (2025-05-30)
## [4.1.0-pre.0](https://github.com/tari-project/tari/compare/v4.0.0-pre.0...v4.1.0-pre.0) (2025-05-30)
🤖 Prompt for AI Agents
In changelog-Mainnet.md at line 5, the changelog header incorrectly shows
version 4.1.0 instead of the pre-release version 4.1.0-pre.0. Update the header
to "## [4.1.0-pre.0]" and modify the compare link to match the pre-release tag,
ensuring consistency with the PR version.

* add sqlite peer_db ([#6963](https://github.com/tari-project/tari/issues/6963)) ([0f1b0dc](https://github.com/tari-project/tari/commit/0f1b0dc386462529512676d177c6316ece8bd20e))
* get all completed txs with pagination ([#7113](https://github.com/tari-project/tari/issues/7113)) ([d292cec](https://github.com/tari-project/tari/commit/d292cecd4c95870947831129f9b476f73bf8ea59))
* new bootstrap process ([#7121](https://github.com/tari-project/tari/issues/7121)) ([e5a0854](https://github.com/tari-project/tari/commit/e5a08540b30084d566a1cfb99336797f50a65b3e))
* remove the ability to send completely raw bytes via grpc ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac28](https://github.com/tari-project/tari/commit/1e7ac281ad7a20f45c6852f131ea44db246f4f72))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate feature entry.

The breaking change "* remove the ability to send completely raw bytes via grpc (#7117)" appears twice—once under ⚠ BREAKING CHANGES (line 10) and again under Features (line 18). Please remove the duplicate from the Features section:

- * remove the ability to send completely raw bytes via grpc ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac28](https://github.com/tari-project/tari/commit/1e7ac281ad7a20f45c6852f131ea44db246f4f72))
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* remove the ability to send completely raw bytes via grpc ([#7117](https://github.com/tari-project/tari/issues/7117)) ([1e7ac28](https://github.com/tari-project/tari/commit/1e7ac281ad7a20f45c6852f131ea44db246f4f72))
🤖 Prompt for AI Agents
In changelog-Mainnet.md at line 18, there is a duplicate entry for the breaking
change about removing the ability to send raw bytes via grpc. Remove the entry
from the Features section at line 18, keeping only the one under the ⚠ BREAKING
CHANGES section at line 10 to avoid redundancy.

@SWvheerden SWvheerden merged commit 4b32faf into tari-project:development May 30, 2025
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant