chore: cleanup revalidation process names

[SWvheerden]

Description

updates names to more clearly show what the code does

Summary by CodeRabbit

• Refactor
  • Improved the accuracy and clarity of transaction status handling for completed transactions that have not been mined. This enhances the reliability of transaction status reporting in the wallet interface.

[coderabbitai]

Walkthrough

This change renames a method for fetching transactions with no mined height in the SQLite database layer, updates all references to this method, and modifies its SQL filter condition to use a more idiomatic null check for the mined height field.

Changes

File(s)	Change Summary
.../sqlite_db.rs	Renamed fetch_transactions_with_mismatched_mined_status to fetch_transactions_with_not_mined_height, updated all usages, and changed the SQL filter to use .is_null() for mined_height.

Possibly related PRs

• fix: mismatched tms db state #7131: Renamed and modified the same method, updating its internal query filter to use a more idiomatic null check, directly building on the method introduced in this PR.

Suggested reviewers

• hansieodendaal

Poem

In the warren of code, a method’s new name,
From mismatched to not mined, it’s never the same.
With null checks more tidy, the queries now hop,
Through SQLite fields where old filters would stop.
🐇✨ A leap for the ledger, the carrots won’t drop!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 652286b and 0c89f9a.

📒 Files selected for processing (1)

• base_layer/wallet/src/transaction_service/storage/sqlite_db.rs (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• base_layer/wallet/src/transaction_service/storage/sqlite_db.rs

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: test (nextnet, nextnet)
• GitHub Check: test (mainnet, stagenet)
• GitHub Check: test (testnet, esmeralda)
• GitHub Check: cargo check with stable
• GitHub Check: ci
• GitHub Check: Cucumber tests / FFI
• GitHub Check: Cucumber tests / Base Layer

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Test Results (CI)

    3 files    104 suites   36m 50s ⏱️
1 330 tests 1 327 ✅ 0 💤 3 ❌
3 092 runs  3 085 ✅ 0 💤 7 ❌

For more details on these failures, see this check.

Results for commit 55ec446.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (Integration tests)

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
2 files    0 ❌
2 errors

For more details on these parsing errors, see this check.

Results for commit 55ec446.

♻️ This comment has been updated with latest results.

[hansieodendaal]

utACK