chore(ci): windows binary audit fix and more code-signing verification#7245
Conversation
…nto common powerShell, add per Windows exe verify before Windows installer build. Move linux-arm64 from cross-rs compile to native runner on Ubuntu 22.04
WalkthroughThis change updates the CI workflow for building binaries. It modifies the build environment for the Linux ARM64 target, refines Windows signature verification steps by introducing a new PowerShell script, and adjusts audit steps for compatibility. A new script, Changes
Sequence Diagram(s)sequenceDiagram
participant CI as GitHub Actions
participant Script as check_signatures.ps1
participant Signtool as signtool.exe
participant PowerShell as Get-AuthenticodeSignature
CI->>Script: Run check_signatures.ps1 with directory or file list
Script->>Signtool: Locate signtool.exe
alt For each .exe file
Script->>PowerShell: Validate signature with Get-AuthenticodeSignature
Script->>Signtool: Validate signature with signtool.exe verify /pa
Script-->>CI: Report warning if validation fails
end
Script-->>CI: Exit with success or failure code
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (7)
🔇 Additional comments (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
leet4tari
changed the title
Test Results (CI) 3 files 126 suites 46m 1s ⏱️ Results for commit a1fa399. |
Test Results (Integration tests) 2 files 10 suites 1h 4m 12s ⏱️ For more details on these failures, see this check. Results for commit a1fa399. |
* development: fix: remove long timeout in interactive_tx till tx is persisted into db (tari-project#7252) chore: new release v4.6.1-pre.0 (tari-project#7248) fix: minotari_merge_mining_proxy returns Tari block hash even if submit_to_origin is disabled (tari-project#7242) chore(ci): windows binary audit fix and more code-signing verification (tari-project#7245) fix: database cannot resize on jmt write (tari-project#7244)
2 participants
Description
Windows binary audit fix
move code-signing verification into common powerShell
add per Windows exe verify before Windows installer build
Move linux-arm64 from cross-rs compile to native runner on Ubuntu 22.04
Motivation and Context
Make sure that audit is included for Windows binaries
Verify Windows exes before build Windows installer
Fix linux-arm64 builds
How Has This Been Tested?
Builds and works as expected in CI workflows
Summary by CodeRabbit
New Features
Chores