fix(node): enable list headers for L2

[sdbondi]

Description

fix(node): enable list headers for L2

Motivation and Context

Needed for validator node to sync headers

[gemini-code-assist]

Summary of Changes

Hello @sdbondi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a critical fix to enable validator nodes to sync headers by activating the ListHeaders gRPC method for second-layer operations. This change directly addresses a functional requirement for L2 node synchronization. Additionally, the PR includes minor but beneficial code improvements such as refactoring method lists into constants and removing redundant imports, contributing to overall code health and efficiency.

Highlights

• L2 Header Sync: Enabled the ListHeaders gRPC method specifically for second-layer (L2) nodes, which is crucial for validator nodes to successfully sync headers.
• Code Refactoring: Converted the mining_method and second_layer_methods arrays in the gRPC server configuration to const arrays, improving performance and clarity.
• Code Cleanup: Removed unused log imports from merkle_proof.rs and block.rs, and an unnecessary .to_vec() call in the gRPC server's method enablement logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly enables the ListHeaders gRPC method for L2 nodes, which is necessary for validator node header synchronization. The changes also include some nice cleanups and performance improvements, such as converting local arrays to const slices and removing an unnecessary vector clone. I've added one suggestion to refactor a series of if statements into a more idiomatic boolean expression for improved readability.

[gemini-code-assist]

For improved readability and conciseness, you can combine these if statements into a single boolean expression.

Suggested change

	if self.config.mining_enabled && MINING_METHOD.contains(&grpc_method) {
	return true;
	}
	if self.config.second_layer_grpc_enabled && second_layer_methods.contains(&grpc_method) {
	if self.config.second_layer_grpc_enabled && SECOND_LAYER_METHODS.contains(&grpc_method) {
	return true;
	}
	self.config.grpc_server_allow_methods.to_vec().contains(&grpc_method)
	self.config.grpc_server_allow_methods.contains(&grpc_method)
	(self.config.mining_enabled && MINING_METHOD.contains(&grpc_method)) ||
	(self.config.second_layer_grpc_enabled && SECOND_LAYER_METHODS.contains(&grpc_method)) ||
	self.config.grpc_server_allow_methods.contains(&grpc_method)