chore: fix most cucumber tests

[SWvheerden]

Description

flags broken tests

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on improving the stability of the continuous integration pipeline by explicitly marking known broken Cucumber tests. This allows the CI to pass for other changes while these specific tests are addressed. Additionally, it includes minor refactoring of test functions and updates to FFI wallet test setup.

Highlights

• Cucumber Test Tagging: Numerous Cucumber feature files have been updated to mark currently failing or unstable scenarios and features with the @broken tag. This includes tests related to Block Explorer GRPC, Merge Mining, Propagation, Reorgs, Sync, Transaction Info, Wallet CLI, Wallet FFI, and Wallet Recovery.
• Dependency Update: The Cargo.lock file was updated, specifically changing the version of minotari_wallet_grpc_client.
• Test Refactoring: Several test functions in base_layer/transaction_components/src/validation/helpers.rs were refactored to remove #[tokio::test] and async keywords, converting them to standard #[test] functions.
• FFI Wallet Enhancements: The FFI wallet integration tests received new Cucumber steps for connecting and restarting FFI wallets, and the Wallet::new function in integration_tests/src/ffi/wallet.rs was updated to accept a base_node_address parameter.

Changelog

• Cargo.lock
  • Updated the version of minotari_wallet_grpc_client to 5.3.0-pre.2.
• base_layer/transaction_components/src/validation/helpers.rs
  • Refactored test functions by removing #[tokio::test] and async keywords, converting them to standard #[test] functions.
• integration_tests/src/ffi/wallet.rs
  • Added a base_node_address parameter to the Wallet::new function and utilized it in the FFI wallet initialization.
• integration_tests/tests/features/BlockExplorerGRPC.feature
  • Marked the Block Explorer GRPC feature and its get the network difficulties scenario as @broken.
• integration_tests/tests/features/MergeMining.feature
  • Tagged multiple Merge Mining scenarios, including 'Functionality Test Without Submitting To Origin', 'Functionality Test With Submitting To Origin', and 'Simple Merge Mining', as @broken.
• integration_tests/tests/features/Propagation.feature
  • Adjusted Block Propagation test examples and marked the 'Pruned node should prune outputs' scenario as @broken.
• integration_tests/tests/features/Reorgs.feature
  • Uncommented and marked several Reorgs scenarios, such as 'Pruned mode reorg simple', 'Pruned mode reorg past horizon', 'Full block sync with small reorg', and 'Full block sync with large reorg', as @broken.
• integration_tests/tests/features/Sync.feature
  • Modified Block Sync test examples and marked multiple sync scenarios, including pruned mode sync tests and peer discovery, as @broken.
• integration_tests/tests/features/TransactionInfo.feature
  • Marked the 'Get Transaction Info' scenario as @broken.
• integration_tests/tests/features/WalletCli.feature
  • Tagged several Wallet CLI scenarios, such as changing base node, setting custom base node, and sending Tari, as @broken.
  • Removed the flaky 'discover-peer' scenario.
• integration_tests/tests/features/WalletFFI.feature
  • Uncommented and marked several Wallet FFI scenarios, including wallet recovery, transaction cancellation, transaction listing, offline receiving, one-sided sending/receiving, and fee per gram stats, as @broken.
• integration_tests/tests/features/WalletRecovery.feature
  • Uncommented and marked wallet recovery scenarios, including 'Wallet recovery with connected base node staying online', 'Multiple Wallet recovery from seed node', and 'Recover one-sided payments', as @broken.
• integration_tests/tests/steps/wallet_ffi_steps.rs
  • Added new Cucumber steps for FFI wallet connection to base and seed nodes.
  • Implemented a new step to restart an FFI wallet.

Activity

• The pull request was created by SWvheerden with the title "chore: mark all broken cucumber tests as broken" and description "flags broken tests". No other activity has been recorded.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[SWvheerden]

/gemini review

[gemini-code-assist]

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.