Skip to content

chore: test cucumber improvements#7731

Merged
SWvheerden merged 13 commits intotari-project:developmentfrom
SWvheerden:sw-impr_cu
Apr 8, 2026
Merged

chore: test cucumber improvements#7731
SWvheerden merged 13 commits intotari-project:developmentfrom
SWvheerden:sw-impr_cu

Conversation

@SWvheerden
Copy link
Copy Markdown
Collaborator

Description

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a standardized wait_for! macro with exponential backoff to replace various manual polling loops across the integration test suite. This change improves code readability and consistency. However, the reviewer identified several instances where the transition to the new macro significantly reduced timeout durations compared to the original implementations. These reductions, found in both node and wallet synchronization steps, could lead to flaky tests in environments where operations take longer than the new 120-second default or the specific hardcoded values. It is recommended to adjust these timeouts to match the previous, more generous durations to ensure test stability.

@SWvheerden SWvheerden merged commit 98ab290 into tari-project:development Apr 8, 2026
16 of 17 checks passed
@SWvheerden SWvheerden deleted the sw-impr_cu branch April 8, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant