chore: test cucumber improvements#7731
Merged
SWvheerden merged 13 commits intotari-project:developmentfrom Apr 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a standardized wait_for! macro with exponential backoff to replace various manual polling loops across the integration test suite. This change improves code readability and consistency. However, the reviewer identified several instances where the transition to the new macro significantly reduced timeout durations compared to the original implementations. These reductions, found in both node and wallet synchronization steps, could lead to flaky tests in environments where operations take longer than the new 120-second default or the specific hardcoded values. It is recommended to adjust these timeouts to match the previous, more generous durations to ensure test stability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description